bug: closing the last tiled window on secondary screen crashes forge (workspace on primary)

[mipmip]

Whan I do this a lot of strange stuff happens and the shell get restarted sort. After a few times I'm forced to restart the gnome session.

[jmmaranan]

Thanks for the report @mipmip - I believe this is due to Forge tracking modal dialogs. Can you provide the last window that you closed? And does it show like a Confirm Exit dialog?

[mipmip]

The steps to reproduce...

1. make sure I'm in tiled mode :)
2. start two alacritty windows on my primary screen
3. start a alacritty window on my secondary screen
4. close the alacritty window on my secondary screen

It can be any application I happens with Firefox, or evolution.

See the video....

video_2021-09-24_14-48-38.mp4

[jmmaranan]

Thanks again for the additional info. I can replicate this when the Workspace on Primary is enabled. The other issue I mentioned about Modal Dialogs is a different issue (does not matter if workspace on primary or not) but also produces the same crash.

[jmmaranan]

@mipmip - added a fix for it. You can check it out from the branch: fix-ws-closing-on-primary, then make dev. Use make uninstall to remove the development version. I think you have to revisit this link: https://extensions.gnome.org/extension/4481/forge/ to get the release version again once I publish and is approved.

[mipmip]

Sorry, this does not fix the problem for my situation. This is my workspace configuration... It happens when I close the last window on the secondary monitor.

[jmmaranan]

I tried to use the same configuration as yours and able to replicate it. Though it is the same fix from #51. I will leave this ticket open and go ahead with the PR as it might affecting some other users.

[jmmaranan]

Here is reproduction and testing in 40 - issue manifesting on the 0:09-0:12 mark after closing Files. Then I applied the patch from main branch after.

2021-09-27.19-29-28.mp4

[mipmip]

I see you merged the fix. I'll dive into the issue later when I have more time. I'm new to Gnome but I like to get dirty hands.

[jmmaranan]

I'm sorry - I do not think I have a fix for your issue yet - since I can easily get that other one in for other users (just updating the delay before the workspace event triggers updating the tree) - not until we can resolve / replicate your ticket on both our sides I will not close this.

[jmmaranan]

One thing I can think of to help is probably exposing the delay (maybe it is hardware sensitive) for that same change I mentioned as an option (maybe a slider in milliseconds) in prefs.js

[jmmaranan]

Just an update - I am now seeing this randomly even with the fix from the other day. But still not sure why it is happening.

[jmmaranan]

Hi @mipmip - just checking in again. Are you still seeing this? I spent a couple of days on gnome 40 and 41, I do not see this happening anymore. I am not sure what I did to fix it though :)