Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare Python 3.9 support #166

Closed
4 tasks done
hugovk opened this issue Oct 2, 2020 · 6 comments
Closed
4 tasks done

Declare Python 3.9 support #166

hugovk opened this issue Oct 2, 2020 · 6 comments
Labels

Comments

@hugovk
Copy link
Collaborator

hugovk commented Oct 2, 2020

Python 3.9.0 is due out on Monday (https://www.python.org/dev/peps/pep-0596/).

We're already testing against 3.9-dev, so let's also declare support for Python 3.9.

Add the 3.9 Trove classifier to setup.py, and also py39 to tox.ini.


If doing this after the release:

  • Check if 3.9-dev can be replaced with plain 3.9 in .travis.yml

  • Also see if the 3.9-dev line can be removed from .github/workflows/test.yml and replaced with "3.9" with the other non-devs.

Important: If doing these, please enable the CIs on your fork and make sure they pass before submitting the PR.

  • Travis CI
  • GitHub Actions
  • Trove classifier
  • Tox
@jaimcamp
Copy link

jaimcamp commented Oct 2, 2020

Hi, could I take this one?

@hugovk
Copy link
Collaborator Author

hugovk commented Oct 2, 2020

@jaimcamp Certainly!

@hugovk
Copy link
Collaborator Author

hugovk commented Oct 19, 2020

@jaimcamp How did you get on?

@jaimcamp
Copy link

Hi @hugovk , I have been waiting Travis support for 3.9 for a while now.
It's still not there (https://docs.travis-ci.com/user/languages/python/#python-versions), but I have opened a WIP PR, which can be merged as soon as Travis adds support for 3.9 #171

@hugovk
Copy link
Collaborator Author

hugovk commented Oct 30, 2020

Travis CI now has 3.9 available.

@jaimcamp
Copy link

jaimcamp commented Nov 1, 2020

Added it again in #176 .

@hugovk hugovk closed this as completed Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants