Fix: AP style for 0 is 'zero' #121

hugovk · 2020-03-05T21:23:26Z

Fixes #72.

Changes proposed in this pull request:

AP style for 0 is "zero", not "0"
The Associated Press Stylebook (p. 203) says:
- Spell out whole numbers up to (and including) nine (e.g., zero, one, 10, 96, 104).
https://apvschicago.com/2011/05/numbers-spell-out-or-use-numerals.html

Before

>>> import humanize
>>> humanize.apnumber(0)
'0'
>>> humanize.apnumber(1)
'one'
>>> humanize.apnumber(2)
'two'
>>>

After

>>> import humanize
>>> humanize.apnumber(0)
'zero'
>>> humanize.apnumber(1)
'one'
>>> humanize.apnumber(2)
'two'
>>>

codecov-io · 2020-03-05T21:24:20Z

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #121   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         410    410           
=====================================
  Hits          410    410

Flag	Coverage Δ
#GHA_Ubuntu	`100% <100%> (ø)`	⬆️
#GHA_Windows	`?`
#GHA_macOS	`?`

Impacted Files	Coverage Δ
tests/test_number.py	`100% <ø> (ø)`	⬆️
src/humanize/number.py	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaca29f...3c13dc0. Read the comment docs.

tmc · 2020-03-05T21:24:28Z

Codecov Report

Merging #121 into master will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #121   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          410       410           
=========================================
  Hits           410       410

Flag	Coverage Δ
#GHA_Ubuntu	`100.00% <100.00%> (ø)`
#GHA_Windows	`?`
#GHA_macOS	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaca29f...3c13dc0. Read the comment docs.

codecov-io · 2020-03-05T21:24:42Z

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #121   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         410    410           
=====================================
  Hits          410    410

Flag	Coverage Δ
#GHA_Ubuntu	`100% <100%> (ø)`	⬆️
#GHA_Windows	`?`
#GHA_macOS	`100% <100%> (ø)`	⬆️

Impacted Files	Coverage Δ
tests/test_number.py	`100% <ø> (ø)`	⬆️
src/humanize/number.py	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaca29f...3c13dc0. Read the comment docs.

tmc · 2020-03-05T21:35:59Z

Codecov Report

Merging #121 into master will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #121   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          410       410           
=========================================
  Hits           410       410

Flag	Coverage Δ
#GHA_Ubuntu	`100.00% <100.00%> (ø)`
#GHA_Windows	`99.02% <100.00%> (-0.98%)`	⬇️
#GHA_macOS	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaca29f...1980b90. Read the comment docs.

codecov-io · 2020-03-05T21:36:39Z

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #121   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         410    410           
=====================================
  Hits          410    410

Flag	Coverage Δ
#GHA_Ubuntu	`100% <100%> (ø)`	⬆️
#GHA_Windows	`100% <100%> (ø)`	⬆️
#GHA_macOS	`100% <100%> (ø)`	⬆️

Impacted Files	Coverage Δ
tests/test_number.py	`100% <ø> (ø)`	⬆️
src/humanize/number.py	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaca29f...a2a8d83. Read the comment docs.

tmc · 2020-03-05T21:37:38Z

Codecov Report

Merging #121 into master will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #121   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          410       393   -17     
=========================================
- Hits           410       393   -17

Flag	Coverage Δ
#GHA_Ubuntu	`100.00% <100.00%> (ø)`
#GHA_Windows	`?`
#GHA_macOS	`?`

Impacted Files	Coverage Δ
tests/test_time.py	`100.00% <0.00%> (ø)`
tests/test_number.py	`100.00% <0.00%> (ø)`
tests/test_filesize.py	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaca29f...a2a8d83. Read the comment docs.

codecov-io · 2020-03-05T21:38:36Z

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #121   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         410    410           
=====================================
  Hits          410    410

Flag	Coverage Δ
#GHA_Ubuntu	`100% <100%> (ø)`	⬆️
#GHA_Windows	`?`
#GHA_macOS	`100% <100%> (ø)`	⬆️

Impacted Files	Coverage Δ
tests/test_number.py	`100% <ø> (ø)`	⬆️
src/humanize/number.py	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaca29f...a2a8d83. Read the comment docs.

tmc · 2020-03-05T21:39:03Z

Codecov Report

Merging #121 into master will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #121   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          410       410           
=========================================
  Hits           410       410

Flag	Coverage Δ
#GHA_Ubuntu	`100.00% <100.00%> (ø)`
#GHA_Windows	`100.00% <100.00%> (ø)`
#GHA_macOS	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaca29f...a2a8d83. Read the comment docs.

codecov-io · 2020-03-05T21:39:04Z

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #121   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         410    410           
=====================================
  Hits          410    410

Flag	Coverage Δ
#GHA_Ubuntu	`100% <100%> (ø)`	⬆️
#GHA_Windows	`100% <100%> (ø)`	⬆️
#GHA_macOS	`100% <100%> (ø)`	⬆️

Impacted Files	Coverage Δ
tests/test_number.py	`100% <ø> (ø)`	⬆️
src/humanize/number.py	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaca29f...a2a8d83. Read the comment docs.

tmc · 2020-03-05T21:39:30Z

Codecov Report

Merging #121 into master will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #121   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          410       410           
=========================================
  Hits           410       410

Flag	Coverage Δ
#GHA_Ubuntu	`100.00% <100.00%> (ø)`
#GHA_Windows	`100.00% <100.00%> (ø)`
#GHA_macOS	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaca29f...a2a8d83. Read the comment docs.

codecov-io · 2020-03-05T21:40:54Z

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #121   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         410    410           
=====================================
  Hits          410    410

Flag	Coverage Δ
#GHA_Ubuntu	`100% <100%> (ø)`	⬆️
#GHA_Windows	`100% <100%> (ø)`	⬆️
#GHA_macOS	`100% <100%> (ø)`	⬆️

Impacted Files	Coverage Δ
tests/test_number.py	`100% <ø> (ø)`	⬆️
src/humanize/number.py	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaca29f...a2a8d83. Read the comment docs.

tmc · 2020-03-05T21:43:08Z

Codecov Report

Merging #121 into master will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #121   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          410       410           
=========================================
  Hits           410       410

Flag	Coverage Δ
#GHA_Ubuntu	`100.00% <100.00%> (ø)`
#GHA_Windows	`100.00% <100.00%> (ø)`
#GHA_macOS	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaca29f...a2a8d83. Read the comment docs.

hugovk added 2 commits March 5, 2020 23:19

Fix: AP style for 0 is 'zero'

2f179b6

Updates

3c13dc0

hugovk added bug Something isn't working changelog: Fixed For any bug fixes labels Mar 5, 2020

hugovk mentioned this pull request Mar 5, 2020

humanize.apnumber(0) should return zero #72

Closed

Update docstring

a2a8d83

hugovk merged commit 1f43d30 into jmoiron:master Mar 9, 2020

hugovk deleted the 72-fix-apnumber-zero branch March 9, 2020 08:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: AP style for 0 is 'zero' #121

Fix: AP style for 0 is 'zero' #121

hugovk commented Mar 5, 2020 •

edited

Loading

codecov-io commented Mar 5, 2020

tmc commented Mar 5, 2020

codecov-io commented Mar 5, 2020

tmc commented Mar 5, 2020

codecov-io commented Mar 5, 2020 •

edited

Loading

tmc commented Mar 5, 2020 •

edited

Loading

codecov-io commented Mar 5, 2020

tmc commented Mar 5, 2020

codecov-io commented Mar 5, 2020

tmc commented Mar 5, 2020

codecov-io commented Mar 5, 2020

tmc commented Mar 5, 2020

Fix: AP style for 0 is 'zero' #121

Fix: AP style for 0 is 'zero' #121

Conversation

hugovk commented Mar 5, 2020 • edited Loading

Before

After

codecov-io commented Mar 5, 2020

Codecov Report

tmc commented Mar 5, 2020

Codecov Report

codecov-io commented Mar 5, 2020

Codecov Report

tmc commented Mar 5, 2020

Codecov Report

codecov-io commented Mar 5, 2020 • edited Loading

Codecov Report

tmc commented Mar 5, 2020 • edited Loading

Codecov Report

codecov-io commented Mar 5, 2020

Codecov Report

tmc commented Mar 5, 2020

Codecov Report

codecov-io commented Mar 5, 2020

Codecov Report

tmc commented Mar 5, 2020

Codecov Report

codecov-io commented Mar 5, 2020

Codecov Report

tmc commented Mar 5, 2020

Codecov Report

hugovk commented Mar 5, 2020 •

edited

Loading

codecov-io commented Mar 5, 2020 •

edited

Loading

tmc commented Mar 5, 2020 •

edited

Loading