Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ndigits option to intcomma #123

Merged
merged 4 commits into from
Mar 20, 2020
Merged

Add ndigits option to intcomma #123

merged 4 commits into from
Mar 20, 2020

Conversation

hugovk
Copy link
Collaborator

@hugovk hugovk commented Mar 9, 2020

Fixes #118.

@hugovk hugovk added enhancement New feature or request changelog: Added For new features labels Mar 9, 2020
@hugovk hugovk mentioned this pull request Mar 9, 2020
Closed
@codecov-io
Copy link

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #123   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         410    399   -11     
=====================================
- Hits          410    399   -11
Flag Coverage Δ
#GHA_Ubuntu 100% <100%> (ø) ⬆️
#GHA_Windows ?
#GHA_macOS ?
Impacted Files Coverage Δ
tests/test_number.py 100% <100%> (ø) ⬆️
src/humanize/number.py 100% <100%> (ø) ⬆️
tests/test_time.py 100% <0%> (ø) ⬆️
tests/test_filesize.py 100% <0%> (ø) ⬆️
src/humanize/filesize.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaca29f...c49cf42. Read the comment docs.

@tmc
Copy link

tmc commented Mar 9, 2020

Codecov Report

Merging #123 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #123   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          410       399   -11     
=========================================
- Hits           410       399   -11
Flag Coverage Δ
#GHA_Ubuntu 100.00% <100.00%> (ø)
#GHA_Windows ?
#GHA_macOS ?
Impacted Files Coverage Δ
src/humanize/number.py 100.00% <100.00%> (ø)
tests/test_number.py 100.00% <100.00%> (ø)
tests/test_time.py 100.00% <0.00%> (ø)
tests/test_filesize.py 100.00% <0.00%> (ø)
src/humanize/filesize.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaca29f...c49cf42. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Mar 9, 2020 •
edited
Loading

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #123   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         410    416    +6     
=====================================
+ Hits          410    416    +6
Flag Coverage Δ
#GHA_Ubuntu 100% <100%> (ø) ⬆️
#GHA_Windows 99.03% <100%> (-0.97%) ⬇️
#GHA_macOS 100% <100%> (ø) ⬆️
Impacted Files Coverage Δ
tests/test_number.py 100% <100%> (ø) ⬆️
src/humanize/number.py 100% <100%> (ø) ⬆️
tests/test_filesize.py 100% <0%> (ø) ⬆️
src/humanize/filesize.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaca29f...c49cf42. Read the comment docs.

@tmc
Copy link

tmc commented Mar 9, 2020

Codecov Report

Merging #123 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #123   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          410       416    +6     
=========================================
+ Hits           410       416    +6
Flag Coverage Δ
#GHA_Ubuntu 100.00% <100.00%> (ø)
#GHA_Windows 100.00% <100.00%> (ø)
#GHA_macOS 100.00% <100.00%> (ø)
Impacted Files Coverage Δ
src/humanize/number.py 100.00% <100.00%> (ø)
tests/test_number.py 100.00% <100.00%> (ø)
tests/test_filesize.py 100.00% <0.00%> (ø)
src/humanize/filesize.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaca29f...c49cf42. Read the comment docs.

1 similar comment
@tmc
Copy link

tmc commented Mar 9, 2020 •
edited
Loading

Codecov Report

Merging #123 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #123   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          410       416    +6     
=========================================
+ Hits           410       416    +6
Flag Coverage Δ
#GHA_Ubuntu 100.00% <100.00%> (ø)
#GHA_Windows 100.00% <100.00%> (ø)
#GHA_macOS 100.00% <100.00%> (ø)
Impacted Files Coverage Δ
src/humanize/number.py 100.00% <100.00%> (ø)
tests/test_number.py 100.00% <100.00%> (ø)
tests/test_filesize.py 100.00% <0.00%> (ø)
src/humanize/filesize.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaca29f...c49cf42. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Mar 9, 2020 •
edited
Loading

Codecov Report

Merging #123 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #123   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          414       416    +2     
=========================================
+ Hits           414       416    +2
Flag Coverage Δ
#GHA_Ubuntu 100.00% <100.00%> (ø)
#GHA_Windows 100.00% <100.00%> (ø)
#GHA_macOS 100.00% <100.00%> (ø)
Impacted Files Coverage Δ
src/humanize/number.py 100.00% <100.00%> (ø)
tests/test_number.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77d943a...7b78c0b. Read the comment docs.

@hugovk hugovk merged commit 4185315 into jmoiron:master Mar 20, 2020
@hugovk hugovk deleted the 118-add-ndigits-to-intcomma branch March 20, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog: Added For new features enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

intcomma() variant needed to handle money
3 participants
@hugovk @codecov-io @tmc