Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round naturaldelta to the nearest #154

Closed
wants to merge 7 commits into from
Closed

Round naturaldelta to the nearest #154

wants to merge 7 commits into from

Conversation

hugovk
Copy link
Collaborator

@hugovk hugovk commented Sep 10, 2020

Fixes #143.

Changes proposed in this pull request:

  • Round naturaldelta to the nearest
  • Leave naturaltime rounding down

@hugovk hugovk added the changelog: Changed For changes in existing functionality label Sep 10, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2020

Codecov Report

Merging #154 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #154   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          556       568   +12     
=========================================
+ Hits           556       568   +12     
Flag Coverage Δ
#GHA_Ubuntu 100.00% <100.00%> (ø)
#GHA_Windows 100.00% <100.00%> (ø)
#GHA_macOS 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/humanize/i18n.py 100.00% <ø> (ø)
src/humanize/time.py 100.00% <100.00%> (ø)
tests/test_time.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345f58b...4b5b33c. Read the comment docs.

@hugovk hugovk mentioned this pull request Sep 10, 2020
@hugovk hugovk added the enhancement New feature or request label Sep 10, 2020
@hugovk hugovk marked this pull request as draft September 30, 2020 16:48
@hugovk
Copy link
Collaborator Author

hugovk commented Apr 10, 2021

This PR is a bit stale I think it would need more refactoring. I'm going to close this, and welcome fresh PRs if someone else would like to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Changed For changes in existing functionality enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rounding
3 participants