Added format_timedelta and support function english_list. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hugovk do you think that this feature has value for |
|
Hi,
I'm still here, but I see there's something about the code needing
localisation, and I've got no idea about that.
You're welcome to use the code though.
Take care,
Chris Norman
…On Sun, 14 Jun 2020 at 23:01, eldipa ***@***.***> wrote:
@hugovk <https://github.com/hugovk> do you think that this feature has
value for humanize? IMHO I think that it has.
I could do the rebase (or reimplementation) needed if there is interest on
this and if @chrisnorman7 <https://github.com/chrisnorman7> is not
available (I would give him credit of course)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#57 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBUZ2OJRUX4VUQANGP5YFDRWVCCTANCNFSM4DN5WN4Q>
.
|
|
Hello, this doesn't need localisation (as the others in time.py also aren't localised), but it does need tests. Thanks! |
hugovk
reviewed
Jun 25, 2020
| @@ -166,3 +166,66 @@ def naturaldate(value): | |||
| return naturalday(value) | |||
|
|
|||
|
|
|||
| def english_list( | |||
There was a problem hiding this comment.
I think this should be an internal function:
Suggested change
| def english_list( | |
| def _english_list( |
| ) | ||
| if seconds and show_seconds: | ||
| fmt.append('%.2f seconds' % seconds) | ||
| return english_list(fmt) |
There was a problem hiding this comment.
Suggested change
| return english_list(fmt) | |
| return _english_list(fmt) |
|
This has been superseded by #137. Thanks both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #48.