-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added NextResultSet implementation #747
base: master
Are you sure you want to change the base?
Conversation
@jmoiron, what is the preferred way of getting something like this included? |
This project appears to have been abandoned I've merged this into my own fork here https://github.com/BenKnigge/sqly |
@BenKnigge Should we use your fork or https://github.com/go-sqlx/sqlx? I recall seeing your name link to that fork as well in another issue or PR comment. |
@dlsniper, what kind of testing do you have in mind? |
Hi @kmpm I've tagged this as needs testing because it's something that would benefit having the automated CI tests in place before merging. I plan to integrate that in the extremely near future and then I think it will be good to go. I'll take a closer look at it in the next couple of weeks or so, there are plenty PRs to get to and this is more complex than some of the other ones. Thank you for being so patient about it and for your contribution. |
The most complex thing with this PR is actually the test. The funtional part of the code is actually quite straight forward . |
Hi @DSniper, what kind of tests are you missing. |
Trying to revive the solution for issue #380
Shamelessly used the stuff that @basvanbeek created in pr #453 but added some testing with postgres.
This would also work with mssql but I didn't want to mess with the test environment.