Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #257 delete amenity cases error 500 #258

Closed
wants to merge 7 commits into from
Closed

Issue #257 delete amenity cases error 500 #258

wants to merge 7 commits into from

Conversation

DDmit04
Copy link
Contributor

@DDmit04 DDmit04 commented Mar 9, 2021 •
edited

🚀 Description

fix 500 error on delete amenity
Closes: #257

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@DDmit04 DDmit04 force-pushed the feature/257--Delete-amenity-cases-error branch 9 times, most recently from 5332ced to 2fbb1bb Compare March 10, 2021 00:16
@codecov
Copy link

codecov bot commented Mar 10, 2021 •
edited

Codecov Report

Merging #258 (e87fcb5) into master (c123298) will decrease coverage by 0.65%.
The diff coverage is 61.53%.

❗ Current head e87fcb5 differs from pull request most recent head 7426ee9. Consider uploading reports for the commit 7426ee9 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #258      +/-   ##
============================================
- Coverage     71.88%   71.23%   -0.66%     
- Complexity      223      224       +1     
============================================
  Files            36       37       +1     
  Lines           939      949      +10     
  Branches         42       45       +3     
============================================
+ Hits            675      676       +1     
- Misses          256      264       +8     
- Partials          8        9       +1
Impacted Files Coverage Δ Complexity Δ
...va/com/myhome/controllers/CommunityController.java 98.64% <ø> (ø) 25.00 <0.00> (ø)
...home/services/springdatajpa/HouseSDJpaService.java 77.77% <0.00%> (-7.59%) 11.00 <0.00> (ø)
...java/com/myhome/controllers/AmenityController.java 85.18% <50.00%> (ø) 10.00 <2.00> (ø)
...me/services/springdatajpa/AmenitySDJpaService.java 88.57% <50.00%> (-9.11%) 7.00 <2.00> (-4.00)
...ices/springdatajpa/AmenityBookingSDJpaService.java 81.81% <81.81%> (ø) 4.00 <4.00> (?)
.../services/springdatajpa/CommunitySDJpaService.java 94.28% <100.00%> (+0.16%) 34.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c123298...7426ee9. Read the comment docs.

@mslowiak
Copy link
Collaborator

Could you rename the PR name and resolve conflicts @DDmit04 ?

@DDmit04 DDmit04 changed the title Feature/257 delete amenity cases error 500 Issue #257 delete amenity cases error 500 Mar 10, 2021
@DDmit04 DDmit04 force-pushed the feature/257--Delete-amenity-cases-error branch from 8bf6f14 to 1a05d7c Compare March 10, 2021 22:06
mslowiak
mslowiak approved these changes Mar 11, 2021
View reviewed changes
service/src/main/java/com/myhome/controllers/CommunityController.java Outdated Show resolved Hide resolved
service/src/main/java/com/myhome/controllers/CommunityController.java Outdated Show resolved Hide resolved
service/src/main/java/com/myhome/controllers/CommunityController.java Outdated Show resolved Hide resolved
service/src/main/java/com/myhome/controllers/CommunityController.java Outdated Show resolved Hide resolved
service/src/test/java/com/myhome/services/unit/AmenityBookingSDJpaServiceTest.java Show resolved Hide resolved
service/src/test/java/com/myhome/services/unit/AmenityBookingSDJpaServiceTest.java Outdated Show resolved Hide resolved
service/src/test/java/com/myhome/services/unit/AmenityBookingSDJpaServiceTest.java Outdated Show resolved Hide resolved
service/src/test/java/com/myhome/services/unit/CommunitySDJpaServiceTest.java Outdated Show resolved Hide resolved
service/src/test/java/com/myhome/services/unit/CommunitySDJpaServiceTest.java Outdated Show resolved Hide resolved
@DDmit04 DDmit04 requested a review from mslowiak March 11, 2021 23:48
mslowiak
mslowiak requested changes Mar 12, 2021
View reviewed changes
Copy link
Collaborator

@mslowiak mslowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash changes beetween 603ad2a86f11a90f86dea1680775b6fdd97fd2a4 and 1c76c92b81ff1b2549b24b20d2c3d685c7ab1581 because the history of codebase is modified by this adding and deleting fields but it should not...
It is related to problematic rebase/merge with master on your side

@DDmit04 DDmit04 force-pushed the feature/257--Delete-amenity-cases-error branch from 938b66f to b73fbf1 Compare March 12, 2021 12:22
@DDmit04 DDmit04 requested a review from mslowiak March 12, 2021 12:24
@DDmit04
Issue jmprathab#257 fix test case name
7426ee9 
(cherry picked from commit a573a07)
@DDmit04
Copy link
Contributor Author

DDmit04 commented Apr 10, 2021

@mslowiak This can be merged?

@mslowiak mslowiak closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidanBurton aidanBurton aidanBurton left review comments

@mslowiak mslowiak Awaiting requested review from mslowiak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete amenity cases error 500
3 participants
@DDmit04 @mslowiak @aidanBurton