Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change access level of properties in PageInfo.java. #236

Merged

Conversation

Tobi406
Copy link
Collaborator

@Tobi406 Tobi406 commented Feb 19, 2021

🚀 Description

Change the access level of the properties in PageInfo.java from private to public

📄 Motivation and Context

To close #235

🧪 How Has This Been Tested?

Postman and the testClasses task

📷 Screenshots (if appropriate)

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

  • My code follows the code style of this project(Do your best to follow code styles. If none apply just skip this).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #236 (d938d98) into master (ec4ecb8) will decrease coverage by 0.63%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #236      +/-   ##
============================================
- Coverage     68.76%   68.12%   -0.64%     
  Complexity      200      200              
============================================
  Files            31       34       +3     
  Lines           858      866       +8     
  Branches         41       41              
============================================
  Hits            590      590              
- Misses          260      268       +8     
  Partials          8        8              
Impacted Files Coverage Δ Complexity Δ
...yhome/services/springdatajpa/UserSDJpaService.java 77.38% <0.00%> (-8.15%) 27.00% <0.00%> (ø%)
...src/main/java/com/myhome/security/WebSecurity.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...om/myhome/security/MyHomeAuthenticationFilter.java
...java/com/myhome/security/AppUserDetailFetcher.java
...ontrollers/exceptions/AuthenticationException.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...lers/exceptions/CredentialsIncorrectException.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
.../controllers/exceptions/UserNotFoundException.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...m/myhome/controllers/AuthenticationController.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...ices/springdatajpa/AuthenticationSDJpaService.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec4ecb8...d938d98. Read the comment docs.

Copy link
Collaborator

@mslowiak mslowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we give it a try by adding @Getter annotation on the top of the class?

@mslowiak mslowiak force-pushed the fix-235/500-thrown-when-requesting-payments branch from 703be06 to d938d98 Compare February 19, 2021 21:32
@Tobi406
Copy link
Collaborator Author

Tobi406 commented Feb 19, 2021

Works perfectly fine, thank you.

@mslowiak mslowiak merged commit c60b96c into jmprathab:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

500 thrown when requesting payments
2 participants