Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locale support for Romanian #12

Closed
jmrozanec opened this issue Apr 18, 2015 · 5 comments
Closed

Add locale support for Romanian #12

jmrozanec opened this issue Apr 18, 2015 · 5 comments

Comments

@jmrozanec
Copy link
Owner

Add support for Romanian similar to @beradrian contribution.

@beradrian
Copy link

I can assist here if needed. Besides translating the resource file is there anything else that should be done? Are there any tests?

@jmrozanec
Copy link
Owner Author

@beradrian We currently have tests only for English language. If you can contribute the translations and add some tests, that would be great. Thank you for looking into this!

@beradrian
Copy link

Take a look here: https://github.com/beradrian/cron-utils/tree/ro-ro

The only problem is that new messages have to be defined at_second, at_minute, at_hour, at_month.

Could you please make use of these in the code? If yes, I can modify the rest of the resources and tests will pass.

There will also be nice if we can have something like between_month_x_and_y and between_weekday_x_and_y. The current one works, but this will enable to have a more natural format in Romanian (possible other languages too).

@jmrozanec
Copy link
Owner Author

@beradrian thank you for the contribution!
I agree on your proposal. To deal with it we may need to do some refactoring on how cron descriptions are being done now. Will work on this on the following days and come back with an idea / workaround. If you have any suggestions, are welcome!

@jmrozanec
Copy link
Owner Author

@beradrian Romanian is now supported! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants