Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect next execution time for ranges #64

Closed
Joao-Neves opened this issue Jan 8, 2016 · 4 comments
Closed

Incorrect next execution time for ranges #64

Joao-Neves opened this issue Jan 8, 2016 · 4 comments
Assignees

Comments

@Joao-Neves
Copy link

Next execution time is not being computed correctly for ranges:

        final CronType cronType = CronType.QUARTZ;
        final CronParser quartzParser = new CronParser(CronDefinitionBuilder.instanceDefinitionFor(cronType));
        ExecutionTime executionTime = ExecutionTime.forCron(quartzParser.parse("* 10-20 * * * * 2099"));
        DateTime nextTime = executionTime.nextExecution(DateTime.now());
        assertNotNull(nextTime);
        assertEquals(10, nextTime.getMinuteOfHour());

This yields:

java.lang.AssertionError: 
Expected :10
Actual   :11

On the last assertion.

@jmrozanec
Copy link
Owner

@Joao-Neves thank you for reporting this!

@kallem
Copy link

kallem commented Feb 2, 2016

@jmrozanec I'd like to also contribute on this library. Is there a channel for general discussion somewhere? I have some general questions which are not related to exactly only single issue.

@jmrozanec
Copy link
Owner

@kallem sure! Feel free to ask questions at gitter. We use that chat for general questions, and to announce new releases.

@jmrozanec
Copy link
Owner

@Joao-Neves @kallem Fixed!

@jmrozanec jmrozanec added done and removed help wanted labels Mar 5, 2016
@jmrozanec jmrozanec self-assigned this Mar 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants