Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev requirements for docs #364

Merged
merged 5 commits into from Dec 10, 2017
Merged

Fix dev requirements for docs #364

merged 5 commits into from Dec 10, 2017

Conversation

fortiema
Copy link
Contributor

@fortiema fortiema commented Dec 3, 2017

  • Add sphinx, sphinx-rtd-theme to dev-requirements.txt
  • Comment out the mock import in docs/conf.py as it is not used by default and mock is not in the requirements file
  • Add .python-version to gitignore

When using `HiddenMarkovModel.from_samples()` with `DiscreteDistribution` and passing custom labels, if name attribute is left to None a TypeError will be raised from the concatenation with string.

- Cast `name` to str to prevent "NoneType + str" TypeError when name is None
- Add test case to prevent regression
* Add sphinx, sphinx-rtd-theme to dev-requirements.txt
* Comment out the `mock` import in `docs/conf.py` as it is not used by default and mock is not in the requirements file
* Add `.python-version` to gitignore
@fortiema fortiema closed this Dec 3, 2017
@fortiema fortiema reopened this Dec 3, 2017
@jmschrei
Copy link
Owner

Thanks!

@jmschrei jmschrei merged commit 8dc018e into jmschrei:master Dec 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants