Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album playback not possible when not all songs of album completely downloaded #188

Closed
arvidortwig opened this issue Jan 28, 2022 · 3 comments
Labels
redesign-beta Issues related to the beta/redsigned version of Finamp

Comments

@arvidortwig
Copy link

Plattform: Android 11 and Finamp 0.5.1

Current behaviour:
I have experienced that it is not possible to play a single song of a downloaded album (in offline mode) if not all of the songs are properly downloaded e.g. one is missing.

Expected behaviour:
It should be possible to play all already downloaded songs even if one is missing.

@arvidortwig arvidortwig changed the title Album Playback not possible when not all downloads complete Album playback not possible when not all songs of album completely downloaded Jan 28, 2022
@jmshrv
Copy link
Owner

jmshrv commented Feb 11, 2022

Are you seeing an error like this?

https://github.com/UnicornsOnLSD/finamp/blob/3668e7d14fd93ac251371aa3c1d8f040b0cca9bb/lib/services/AudioServiceHelper.dart#L200

I think the current behaviour is just to fail entirely if a song is missing, but I could change it to just skip non-downloaded songs.

@joestrong
Copy link

It should definitely skip. If you press any single song on album view in offline mode, when one of the others isn't downloaded nothing happens at all.

@Chaphasilor
Copy link
Collaborator

@arvidortwig @joestrong the download system has been improved as part of the redesign beta. Meta data for albums and playlists is now downloaded, so that any songs that are not downloaded will be shown grayed-out. They will also be ignored during playback. You can check it out here: https://github.com/jmshrv/finamp/releases/tag/0.9.2-beta

I'll close this issue for now since it should be resolved.

@Chaphasilor Chaphasilor added the redesign-beta Issues related to the beta/redsigned version of Finamp label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redesign-beta Issues related to the beta/redsigned version of Finamp
Projects
Status: Done
Development

No branches or pull requests

4 participants