Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Downloaded/offline songs doesn't have lyrics #739

Closed
Extarys opened this issue May 23, 2024 · 6 comments
Closed

[Bug] Downloaded/offline songs doesn't have lyrics #739

Extarys opened this issue May 23, 2024 · 6 comments
Labels
bug Something isn't working downloading Issues related to the download system redesign-beta Issues related to the beta/redsigned version of Finamp

Comments

@Extarys
Copy link

Extarys commented May 23, 2024

It seems that downloading a playlist still shows those songs has having lyrics on the playlist view, but then when playing that song the UI show that there are no lyrics.

I tried repairing the download while online as suggested by a user, but it didn't fix the issue. I'm on 0.9.7 (latest beta).

Related:
#731

This is not a bug because maybe it's simply not yet implemented. Thanks for the amazing releases, I really enjoy Finamp.

@Chaphasilor
Copy link
Collaborator

Interesting. What do you currently have downloaded? The playlist itself, or only some tracks from that playlist?

And I assume the lyrics icon is also shown in offline mode?

Either way, if you could get us some logs, that might help diagnose the issue :)

@Chaphasilor Chaphasilor added bug Something isn't working downloading Issues related to the download system redesign-beta Issues related to the beta/redsigned version of Finamp labels May 23, 2024
@Extarys
Copy link
Author

Extarys commented May 23, 2024

Indeed, I've downloaded the whole playlist using the upper right download button inside that playlist.

In online mode, the lyrics icon is shown on the left of the track in list view, the bottom right "Lyrics" icon is crossed, no lyrics is shown when clicking the button.

In offline mode, the lyrics icon is shown on the left of the track in list view, the bottom right "Lyrics" icon is not crossed, lyrics works.

Is there a way to clear the log and start fresh ? There is a lot of noise in the Logs section.
Also, do you simply want me to play a song in online mode, then try to play the same song in offline mode and upload the log file? Or would you prefer I create a playlist with a single song and send the logs from the moment I download the playlist? Not sure what would be best for the collaborators. Let me know.

@Extarys Extarys changed the title [Feature request] Downloaded/offline songs doesn't have lyrics [Bug] Downloaded/offline songs doesn't have lyrics May 23, 2024
@Chaphasilor
Copy link
Collaborator

Logs are a bit finnicky still. If you don't mind, just send all of them and I'll take a look at the relevant sections.

The behavior you are describing is the exact opposite of the title and your original comment though. Could you please confirm that lyrics are not working in online mode, but working in offline mode?
And if that's the case, do you see the lyrics in the Jellyfin web app?

It could be that lyrics aren't properly cleared from downloads if you remove the lyrics in Jellyfin...

@Extarys
Copy link
Author

Extarys commented May 25, 2024

The title might appear misleading, but it is still accurate IMO, maybe removing "Offline" from the title might be less confusing. Downloaded songs, while online, doesn't have lyrics, as you said :)
Jellyfin show the lyrics, Finamp also shows the lyrics if the song isn't downloaded, or if I toggle the offline mode On.

Logs attached. Here is what I did.

  • Cleared the app cache
  • Re-logged in
  • Played a song with lyrics (Misere Mani from Era)
  • Taped the button to show the lyrics on the player screen to confirm it has lyrics
  • Downloaded the song
  • Replay the song by re-tapping it in the list of songs from that album
  • Taped the button to show the lyrics - no lyrics were shown
  • Toggled offline mode On
  • Replay the song by re-tapping it in the list of downloaded songs
  • Taped the button to show the lyrics, lyrics are shown

finamp-logs.txt

Note that the app crashed during those steps, which might add some useful noise for another issue haha

@Chaphasilor
Copy link
Collaborator

Ahh I see. Yes, I'm able to reproduce the issue and will look into it!

@Extarys
Copy link
Author

Extarys commented May 26, 2024

Ahh I see. Yes, I'm able to reproduce the issue and will look into it!

Thank you ! I'm always a bit afraid of an issue being non-reproducible 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working downloading Issues related to the download system redesign-beta Issues related to the beta/redsigned version of Finamp
Projects
Status: Done
Development

No branches or pull requests

2 participants