-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Downloaded/offline songs doesn't have lyrics #739
Comments
Interesting. What do you currently have downloaded? The playlist itself, or only some tracks from that playlist? And I assume the lyrics icon is also shown in offline mode? Either way, if you could get us some logs, that might help diagnose the issue :) |
Indeed, I've downloaded the whole playlist using the upper right download button inside that playlist. In online mode, the lyrics icon is shown on the left of the track in list view, the bottom right "Lyrics" icon is crossed, no lyrics is shown when clicking the button. In offline mode, the lyrics icon is shown on the left of the track in list view, the bottom right "Lyrics" icon is not crossed, lyrics works. Is there a way to clear the log and start fresh ? There is a lot of noise in the Logs section. |
Logs are a bit finnicky still. If you don't mind, just send all of them and I'll take a look at the relevant sections. The behavior you are describing is the exact opposite of the title and your original comment though. Could you please confirm that lyrics are not working in online mode, but working in offline mode? It could be that lyrics aren't properly cleared from downloads if you remove the lyrics in Jellyfin... |
The title might appear misleading, but it is still accurate IMO, maybe removing "Offline" from the title might be less confusing. Downloaded songs, while online, doesn't have lyrics, as you said :) Logs attached. Here is what I did.
Note that the app crashed during those steps, which might add some useful noise for another issue haha |
Ahh I see. Yes, I'm able to reproduce the issue and will look into it! |
Thank you ! I'm always a bit afraid of an issue being non-reproducible 🎉 |
It seems that downloading a playlist still shows those songs has having lyrics on the playlist view, but then when playing that song the UI show that there are no lyrics.
I tried repairing the download while online as suggested by a user, but it didn't fix the issue. I'm on 0.9.7 (latest beta).
Related:
#731
This is not a bug because maybe it's simply not yet implemented. Thanks for the amazing releases, I really enjoy Finamp.
The text was updated successfully, but these errors were encountered: