Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded track details panel doesn't render background completely #744

Open
Maxr1998 opened this issue May 23, 2024 · 6 comments · Fixed by #749
Open

Expanded track details panel doesn't render background completely #744

Maxr1998 opened this issue May 23, 2024 · 6 comments · Fixed by #749
Labels
bug Something isn't working design Design changes high priority redesign-beta Issues related to the beta/redsigned version of Finamp

Comments

@Maxr1998
Copy link
Contributor

Maxr1998 commented May 23, 2024

When long pressing a track and then expanding the bottom sheet, the background doesn't cover the whole sheet and is instead black translucent.

Screenshot

Screenshot

@Maxr1998 Maxr1998 changed the title Track details panel doesn't fully render background Expanded track details panel doesn't render background completely May 23, 2024
@Chaphasilor
Copy link
Collaborator

This only happens when not on the player screen. The playlist actions menu is also affected.

@Chaphasilor
Copy link
Collaborator

@Komodo5197 I guess this broke when switching to using the generic menu. Mind taking a look?

@Chaphasilor Chaphasilor added bug Something isn't working design Design changes high priority redesign-beta Issues related to the beta/redsigned version of Finamp labels May 24, 2024
@Komodo5197
Copy link

This is most likely related to the CachePaint widget not redrawing with the new size correctly. It doesn't seem to be reproducing for me though?

@Chaphasilor
Copy link
Collaborator

I only have the issue in the release build on Android. Could that be it?

@Komodo5197
Copy link

Maybe? I’ll try a release build later.

@Komodo5197
Copy link

It does seem to be a release-only issue. I've put a fix into #749.

@Chaphasilor Chaphasilor linked a pull request May 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design Design changes high priority redesign-beta Issues related to the beta/redsigned version of Finamp
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants