Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Despite synchronising playback to the server, songs are not scrobbled to last.fm #87

Closed
el-tiuri opened this issue Jul 21, 2021 · 27 comments · Fixed by #484
Closed

Despite synchronising playback to the server, songs are not scrobbled to last.fm #87

el-tiuri opened this issue Jul 21, 2021 · 27 comments · Fixed by #484

Comments

@el-tiuri
Copy link

el-tiuri commented Jul 21, 2021

Now, I have no clue if the issue here is with FinAmp or the last.fm plugin. Either way, as the title says, in the admin dashboard I can verify that it is reporting my account playing the song I’m actually playing. However, no music is ever scrobbled despite the last.fm being configured for my account.

It just works with the main Jellyfin app, so I’m wondering if FinAmp might report the tracks being played in a slightly different way or something. I’m on iOS, should that make a difference.

@jmshrv
Copy link
Owner

jmshrv commented Jul 21, 2021

Finamp probably isn't doing the full track reporting properly, I'll look into it.

@jmshrv
Copy link
Owner

jmshrv commented Jul 26, 2021

It was working fine for me, does last.fm work when you play songs via the Jellyfin web interface?

@vdatanet
Copy link

Yes, when I play using Jellyfin web interface, it scrobbles to last.fm. FinAmp it doesn't, but used to work. I'd swear it worked last week.

@el-tiuri
Copy link
Author

Same for me. Scrobbling works when using the web interface or the Jellyfin app, but not when using FinAmp.

@vdatanet
Copy link

Even the songs don’t appear as recently played on Jellyfin’s music recommendations.

@deafmute1
Copy link

+1 on this, neither the listenbrainz nor the lastfm scrobbler plugins work for me via finamp. Scrobbling does work for the following clients for me:

  • mopidy
  • web UI
  • official desktop client.

Just started using finamp, so can't speak to it being new or old issue.

@gerardlouw
Copy link

gerardlouw commented Aug 2, 2021

In jesseward/jellyfin-plugin-lastfm#27 (comment) it is mentioned that the plugin expects a PlaybackStartEvent and PlaybackStopEvent pair to be received by the Jellyfin server for it to register a scrobble. I did a quick code search here and did not find any direct references to these, so I believe that may be what is required for a fix.

@jmshrv
Copy link
Owner

jmshrv commented Aug 6, 2021

Should be fixed in 7d56bdd, I'll close this when someone else can verify that it works

@vdatanet
Copy link

vdatanet commented Aug 7, 2021

Hi,

In 0.5.1 scrobbling to last.fm is fixed and played songs are correctly registered in recently played songs in Jellyfin.

Thanks!

@gerardlouw
Copy link

For me on 0.5.1 it is correctly showing the "start" and "finish" events in the Jellyfin activity log. On last.fm it shows that I am busy listening to the song while it is playing, but once it finishes it the scrobble is not actually recorded. Maybe this is a problem not with Finamp.

@el-tiuri
Copy link
Author

el-tiuri commented Aug 8, 2021

It works for me, but seemingly only with music I haven’t downloaded to my phone.

@vdatanet
Copy link

vdatanet commented Aug 8, 2021

Last track of a queue is scrobbled twice:

Captura de pantalla 2021-08-08 122401
Captura de pantalla 2021-08-08 122331

@jmshrv
Copy link
Owner

jmshrv commented Aug 18, 2021

It works for me, but seemingly only with music I haven’t downloaded to my phone.

It won't scrobble in offline mode, but it should still scrobble downloaded songs when not in offline mode.

@jmshrv
Copy link
Owner

jmshrv commented Aug 18, 2021

Double scrobbling is hopefully fixed in 98da06d, I'll test it properly next time I use the app

@el-tiuri
Copy link
Author

It works for me, but seemingly only with music I haven’t downloaded to my phone.

It won't scrobble in offline mode, but it should still scrobble downloaded songs when not in offline mode.

Weird, I’d swear it didn’t work before, but it does now. That’s fantastic!

Is syncing the playback state when you take your device back online planned, by the way? I’d love for scrobbling to work in offline mode.

@carks32
Copy link

carks32 commented Aug 22, 2021

maybe it's a me problem since this got fixed for so many people but it seems that starting a playlist/album just doesn't work to scrobble, they appear just fine on the activity tab and they do appear as scrobbling on last.fm but they never end up getting scrobbled.
image

@jmshrv
Copy link
Owner

jmshrv commented Aug 22, 2021

Is syncing the playback state when you take your device back online planned, by the way? I’d love for scrobbling to work in offline mode.

If Jellyfin has a proper way to send bulk playback data, I'll add support. I don't want to just spam start/end playbacks though

@jmshrv
Copy link
Owner

jmshrv commented Aug 22, 2021

maybe it's a me problem since this got fixed for so many people but it seems that starting a playlist/album just doesn't work to scrobble, they appear just fine on the activity tab and they do appear as scrobbling on last.fm but they never end up getting scrobbled.
image

I think last.fm lags behind a bit, could you check after a few hours?

@carks32
Copy link

carks32 commented Aug 22, 2021

I think last.fm lags behind a bit, could you check after a few hours?

after 16 hours, it seems that is just not the case. How could I try to get you logs while I try to replicate this?

@jmshrv
Copy link
Owner

jmshrv commented Aug 22, 2021

The music I listened to last night wasn't synced, so it might actually still be an issue. I'll look into it more

@jmshrv
Copy link
Owner

jmshrv commented Aug 22, 2021

Progress updates are slightly different in the branch I'm working on right now, so there isn't much point in sending logs at the moment.

@icyphox
Copy link

icyphox commented Nov 11, 2021

hey, apologies for bumping an old issue, but i’m facing this exact bug on iOS 15, downloaded from the App Store.

@jmshrv
Copy link
Owner

jmshrv commented Nov 11, 2021

I still haven't released those improvements from August, new release soon™ (hopefully before the end of November)

@Maxr1998
Copy link
Contributor

Maxr1998 commented Mar 10, 2022

I'm still using the build from last August, but (EDIT: this still applies on the latest master) I think I know why it doesn't submit even if both start and stop events register correctly.

The ListenBrainz plugin (and likely Last.fm too) only submits listens if a (configurable) minimum percentage of the track was played, this requires the stop event to contain the correct duration value. According to the logs on my server, the value is way too small, causing the listen to get dropped.

Listen to '…' won't be submitted, played 0.0008246693926028897% (15770 ticks), required 50% or 2400000000 ticks

It seems that it uses the progress for the following track in the stop event, which is still at the start.

@sseneca
Copy link

sseneca commented Dec 1, 2022

Has there been any progress on this? There's been a release since this issue but afaict it still doesn't scrobble (tested with the listenbrainz plugin)

@Chaphasilor
Copy link
Collaborator

@Maxr1998 initially fixed this in #200, and #484 should adapt his changes into the new queue system...

@Chaphasilor Chaphasilor linked a pull request Oct 3, 2023 that will close this issue
34 tasks
@Chaphasilor
Copy link
Collaborator

Playback reporting and scrobbling has been improved as part of the redesign beta. You can check it out here: https://github.com/jmshrv/finamp/releases/tag/0.9.2-beta

I'll close this issue for now since it should be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

10 participants