Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use module.exports syntax #1

Merged
merged 1 commit into from
Feb 21, 2017
Merged

Use module.exports syntax #1

merged 1 commit into from
Feb 21, 2017

Conversation

lbarasti
Copy link

No description provided.

@lbarasti
Copy link
Author

This prevents the browser from complaining about unexpected token export in some settings - such us when running an app created via create-react-app

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 432bead on lbarasti:use-module-exports-syntax into 065dede on jmsmyth:master.

@jmsmyth
Copy link
Owner

jmsmyth commented Feb 21, 2017

Looks fine. Ideally I'd prefer to keep it using es modules, but its fine to switch to commonjs for now if it fixes things for you. I'm a bit surprised create-react-app doesn't support es modules already, but it could be because this module doesn't have the jsnext:main or module properties in its package.json..

@jmsmyth jmsmyth merged commit a4816a1 into jmsmyth:master Feb 21, 2017
@lbarasti lbarasti deleted the use-module-exports-syntax branch February 21, 2017 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants