Cleanup Finch Python installation #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylelaker
force-pushed
the
fix-finch-paths
branch
from
9bed37b
to
25a3dca
Compare
We actually always want to ensure that the `finch.install_path` directory exists and now that we're using `checksum` on `get_url` that won't execute if the hash matches. We can then selectively unarchive the `zip` only when the download changed something. Even still, we may want to eventually consider always unarchiving.
The contents that we're looking for are actually within the folder within the zip (FinchPython120). We add this as a new variable that's available (though it's rather unlikely to change) and use that for these two environment variables.
Recent versions of the zip file have created a __pycache__ directory that has `.pyc` files for `finch.py` and `finchconnection.py` for CPython 3.6 and 3.9; however, we really probably want to avoid having users actually use those .pyc files.
kylelaker
force-pushed
the
fix-finch-paths
branch
from
25a3dca
to
c407ee6
Compare
ripleymj
approved these changes
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generally improves the process we are using for downloading, extracting, and configuring
the Finch Python installation. We remove some unnecessary pycache files and properly set the
environment variables to prevent import errors and other problems when users actually try to
use the package.
Resolves: #450