Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming be_almost_equal to almost_equal #72

Merged
merged 1 commit into from May 21, 2016

Conversation

jmvrbanac
Copy link
Owner

No description provided.

@jmvrbanac
Copy link
Owner Author

jmvrbanac commented May 20, 2016

@alexanderad I was playing around with the be_almost_equal expect and it didn't sound right when I was reading a full expect line out loud. As a result, I dropped the be_.
So it looks like:

expect(this_thing).to.almost_equal(that_thing, places=7)

What do you think?

@coveralls
Copy link

coveralls commented May 20, 2016

Coverage Status

Coverage increased (+0.004%) to 95.582% when pulling 014e4f3 on renaming_be_almost_equal into 802db97 on master.

@alexanderad
Copy link
Contributor

That's still cool :)

@jmvrbanac jmvrbanac merged commit f3eb56c into master May 21, 2016
@jmvrbanac jmvrbanac deleted the renaming_be_almost_equal branch May 21, 2016 06:41
@jmvrbanac jmvrbanac added this to the 0.5.0 milestone May 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants