Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed __name__ to be more descriptive #125

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

fragmuffin
Copy link
Contributor

At this time the value of __name__ in the base script being run within FreeCAD is:

  • cqgi: __builtins__
  • non-cqgi: temp_module

This update changes this value to:

  • cqgi: __cqgi__
  • non-cqgi: __cq_freecad_module__

What do you think? I'm open to suggestions if you don't like that naming 馃槃

@fragmuffin
Copy link
Contributor Author

@jmwright
One of the changed files is cadquery.cqgi. How do you handle changes to cadquery in this project?
Would you like me to create a complementary PR to @dcowden 's cadquery project as well?

@jmwright
Copy link
Owner

@fragmuffin Thanks for the contribution.

Would you like me to create a complementary PR to @dcowden 's cadquery project as well?

Yes, please do.

I had CadQuery set up as a sub-module at one time so that cross-contributions could be managed properly, but it broke the FreeCAD add-ons manager's ability to install the module. They've since accepted my PR to fix that, but there's still the issue that GitHub doesn't include submodules in zip/tar.gz downloads, which complicates the manual install process for the module.

fragmuffin added a commit to fragmuffin/cadquery-dcowden that referenced this pull request Jun 16, 2018
@jmwright jmwright merged commit 4fc32ec into jmwright:master Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants