-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibratoWriter includes descriptive User-Agent #85
Comments
Hi @mheffner, is there a way to test on our Librato account (email: admin@jmxtrans.org)? I can't wireshark an HTTPS call :-(.
I want to output the HTTP Request Header:
Which is the result of: "embedded-jmxtrans/1 " + "(" +
System.getProperty("java.vm.name") + "/" + System.getProperty("java.version") + "; " +
System.getProperty("os.name") + "-" + System.getProperty("os.arch") + "/" + System.getProperty("os.version")
+ ")";
|
@cyrille-leclerc Yes, I can check what appears in our log files (we log the UA) for your account. Can you give me a time you are testing and if possible the IP address of the sending machine? You can email me at mike_at_librato_com privately too. |
@mheffner I just purged my metrics and re-injected around 4:25 PM GMT on our Librato account (email: admin@jmxtrans.org):
|
This is the UA I see: Looks good to me. Is "1" an accurate representation of the current version or is that a placeholder? |
Thanks @mheffner, This looks pretty good. I wanted to have the details of the JVM as embedded-jmxtrans is using the HTTP connection provided by the JVM. "1" is "1.x" because I did not yet implement the lookup of the maven version in the jar file. @gehel is working on jmxtrans2 which will be able to clearly mention the version of the library. Cyrille |
Release 1.0.13 is cut, it will soon be available in Maven Central Repository. |
Copy of jmxtrans/jmxtrans#216
@mheffner said
The text was updated successfully, but these errors were encountered: