You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following 2 constructors for Query assume resultAlias as the attributeName.
This works fine if we are polling limited set of attributes and attribute names are self-explanatory. However, with the #34 we are allowing capability to export all the attributes and that IMO makes this assumption unnecessary.
If user does not specify the resultAlias, then we can rely on ResultNameStrategy to generate the appropriate name comprised of <objectname>.<attribute-name>.
@cyrille-leclerc Sure, I understand. But, whenever you take a look, please respond to all the issues & pull requests (i.e. in bulk), so that we can make good progress.
Following 2 constructors for
Query
assumeresultAlias
as theattributeName
.This works fine if we are polling limited set of attributes and attribute names are self-explanatory. However, with the #34 we are allowing capability to export all the attributes and that IMO makes this assumption unnecessary.
If user does not specify the
resultAlias
, then we can rely on ResultNameStrategy to generate the appropriate name comprised of<objectname>.<attribute-name>
.Sponsored by: Lookout, Inc.
The text was updated successfully, but these errors were encountered: