Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export everything if the query does not define attribute or key to collec #34

Closed
maheshkelkar opened this issue May 26, 2015 · 0 comments · Fixed by #35
Closed

Export everything if the query does not define attribute or key to collec #34

maheshkelkar opened this issue May 26, 2015 · 0 comments · Fixed by #35

Comments

@maheshkelkar
Copy link
Contributor

As discussed in pull request #29 by @cyrille-leclerc and @petermodzelewski, creating an issue to allow support for:

Adding more power for XML configuration

  • adding support for ALL attributes, when no attribute is specified
  • adding support for ALL keys, when no key is specified for CompositTypes

Following changes were made as a result:

  • Allow null attribute
  • Method getResultName() in ResultNameStrategy was modified to pass attributeName, because query.getAttributeName() could be null
  • Added tests for covering wildcard tests.

It will allow support for following configurations:

<queries>                     
    <query/>
</queries>
<queries>                     
    <query objectName="java.lang:type=Memory"/>
</queries>

Sponsored by: Lookout, Inc.

@maheshkelkar maheshkelkar changed the title Export evereything if the query does not define attribute or key to collect Export everything if the query does not define attribute or key to collec May 26, 2015
maheshkelkar added a commit to maheshkelkar/jmxtrans-agent that referenced this issue May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant