Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for different collect intervals #56

Closed
kerlandsson opened this issue Dec 7, 2015 · 3 comments
Closed

Support for different collect intervals #56

kerlandsson opened this issue Dec 7, 2015 · 3 comments

Comments

@kerlandsson
Copy link
Member

We would like to collect some of our metrics more frequently than others. Hence we would like support for specifying different collect intervals.

If we can agree on how it should work we are prepared to implement it. The most simple solution I see is to allow for an override on query and invocation elements:

<query objectName="java.lang:type=Threading" attribute="ThreadCount" resultAlias="jvm.thread"
  collectIntervalInSeconds="10"/>

This override would be used when specified. The default would be used for queries which do not have an override.

Another option would to add support for groups of queries/invocations where some configuration parameters could be overridden on group level. Something like:

<queries>
  <group name="foo">
    <query ... />
    <invocation ... />
    <collectIntervalInSeconds>10</collectIntervalInSeconds>
  </group>
  <group name="bar">
  ...
  </group>
  <!-- defaults -->
  <collectIntervalInSeconds>20</collectIntervalInSeconds>
</queries>

While I can see the benefits of groups in overriding other parameters (e.g. distinct output writers per group), it is a larger change which adds a bit of complexity.

Any thoughts on this?

@kerlandsson
Copy link
Member Author

@cyrille-leclerc I am probably going to work on this shortly. What are your thoughts? I'm leaning towards supporting a collectIntervalInSeconds override on query/invocation elements.

@cyrille-leclerc
Copy link
Member

Thanks!

FYI I am working on introducing the Resource API (HTTP, Classpath & File
System).

Cyrille

On Thu, Feb 4, 2016 at 4:22 PM, Kristoffer Erlandsson <
notifications@github.com> wrote:

@cyrille-leclerc https://github.com/cyrille-leclerc I am probably going
to work on this shortly. What are your thoughts? I'm leaning towards
supporting a collectIntervalInSeconds override on query/invocation
elements.


Reply to this email directly or view it on GitHub
#56 (comment)
.

Cyrille Le Clerc
email & gtalk : cleclerc@cloudbees.com / mob: +33-6.61.33.69.86 / skype:
cyrille.leclerc
CloudBees, Inc
www.cloudbees.com

@kerlandsson
Copy link
Member Author

Implemented in 1.2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants