Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upto Ruby 2.5.1 #27

Merged
merged 7 commits into from
Jun 25, 2018
Merged

Update upto Ruby 2.5.1 #27

merged 7 commits into from
Jun 25, 2018

Conversation

jnbt
Copy link
Owner

@jnbt jnbt commented May 18, 2018

As this gem is currently stuck on Google::APIClient with version 0.8.6 we need to manually set the User-Agent header as Google::APIClient::ENV::OS_VERSION includes a invalid newline character.

This change mimics the old user agent so an update should be safe.

@coveralls
Copy link

coveralls commented May 18, 2018

Coverage Status

Coverage increased (+1.4%) to 99.93% when pulling 04232b9 on update-ruby into a61a689 on master.

@jnbt
Copy link
Owner Author

jnbt commented May 18, 2018

Tests are OK for all Ruby versions. Only rubocop is crashing / failing for older Ruby versions.

@jnbt
Copy link
Owner Author

jnbt commented May 18, 2018

@sajmoon Can you try the version from this branch?

gem "candy_check", git: "git@github.com:jnbt/candy_check.git", branch: "update-ruby"

@sajmoon
Copy link

sajmoon commented May 22, 2018

@jnbt, as I said in the issue, we have verified this fix for our use case and system. We upgraded to 2.4.4, not 2.5.1 though.

I see there are some problems in travis. When can we expect a release of this?

@cheerfulstoic
Copy link

We also ran into this going from Ruby 2.3.6 to 2.3.7. We're going to try out the fix to see if it helps (though it looks like the exact same issue, so I imagine it will)

@jnbt
Copy link
Owner Author

jnbt commented Jun 25, 2018

@cheerfulstoic Have you tried this branch? Any feedback is welcome before releasing this patch.

@sajmoon
Copy link

sajmoon commented Jun 25, 2018

We have migrated to 2.5.1 without any visible problems. 👍

@cheerfulstoic
Copy link

We were able to upgrade to 2.3.7 with this patch without problems.

Thanks!

@jnbt jnbt merged commit 28872f9 into master Jun 25, 2018
@jnbt jnbt deleted the update-ruby branch June 25, 2018 12:43
@jnbt
Copy link
Owner Author

jnbt commented Jun 25, 2018

Released as 0.1.2

@pfeiffer pfeiffer mentioned this pull request Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants