-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update upto Ruby 2.5.1 #27
Conversation
The user agent did hold a newline character on certain platforms due to the creation of OS_VERSION https://github.com/google/google-api-ruby-client/blob/v0.8.6/lib/google/api_client/environment.rb
Tests are OK for all Ruby versions. Only rubocop is crashing / failing for older Ruby versions. |
@sajmoon Can you try the version from this branch?
|
@jnbt, as I said in the issue, we have verified this fix for our use case and system. We upgraded to 2.4.4, not 2.5.1 though. I see there are some problems in travis. When can we expect a release of this? |
We also ran into this going from Ruby 2.3.6 to 2.3.7. We're going to try out the fix to see if it helps (though it looks like the exact same issue, so I imagine it will) |
@cheerfulstoic Have you tried this branch? Any feedback is welcome before releasing this patch. |
We have migrated to 2.5.1 without any visible problems. 👍 |
We were able to upgrade to 2.3.7 with this patch without problems. Thanks! |
Released as 0.1.2 |
As this gem is currently stuck on
Google::APIClient
with version0.8.6
we need to manually set theUser-Agent
header asGoogle::APIClient::ENV::OS_VERSION
includes a invalid newline character.This change mimics the old user agent so an update should be safe.