Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend logic for obtaining todays date #42

Merged
merged 1 commit into from Nov 7, 2019
Merged

Conversation

jnbt
Copy link
Owner

@jnbt jnbt commented Nov 7, 2019

Porting the changes of @ricky-crichq to the new Google API

Date.today respects the system time zone when we should be using UTC.
This change returns the current day in the UTC time zone.

Candy Check issue: #20

@jnbt jnbt self-assigned this Nov 7, 2019
@jnbt jnbt force-pushed the fix-todays-date-always-utc branch from 97280aa to e66d5e2 Compare November 7, 2019 12:53
@coveralls
Copy link

coveralls commented Nov 7, 2019

Coverage Status

Coverage decreased (-0.02%) to 98.424% when pulling 81b2e7b on fix-todays-date-always-utc into 430c205 on master.

`Date.today` respects the system time zone when we should be using UTC.
This change returns the current day in the UTC time zone.

Candy Check issue: #20

--------------------------------

Also disabled Rubocop style for prefering DateTime
@jnbt jnbt force-pushed the fix-todays-date-always-utc branch from e66d5e2 to 81b2e7b Compare November 7, 2019 13:44
@jnbt jnbt removed the request for review from christophweegen November 7, 2019 13:54
@jnbt jnbt merged commit 0f4fb83 into master Nov 7, 2019
@jnbt jnbt deleted the fix-todays-date-always-utc branch February 23, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants