Add server ACK for consumable #50
Conversation
|
@gerard-morera Looks promising. Can you please also extend the README to describe this feature? @christophweegen Can you please have a general review of this PR? |
There was a problem hiding this comment.
Hello @gerard-morera,
thanks for contributing. LGTM besides some minor typos.
As @jnbt already pointed out, documenting your feature in the README would be great, otherwise people won't even know it's there :-)
| end | ||
|
|
||
| def call! | ||
| acknowlege! |
There was a problem hiding this comment.
Typo: please rename to acknowledge!
|
|
||
| private | ||
|
|
||
| def acknowlege! |
There was a problem hiding this comment.
Typo: please rename to acknowledge!
spec/play_store/acknowledger_spec.rb
Outdated
| let(:authorization) { CandyCheck::PlayStore.authorization(json_key_file) } | ||
|
|
||
| describe "#acknowledge_product_purchase" do | ||
| it "when acknowlegement succeeds" do |
There was a problem hiding this comment.
Typo: please rename to acknowledgement
| let(:authorization) { CandyCheck::PlayStore.authorization(json_key_file) } | ||
|
|
||
| describe "#call!" do | ||
| it "when acknowlegement succeeds" do |
There was a problem hiding this comment.
Typo: please rename to acknowledgement
gerard-morera
force-pushed
the
feature/add-server-ack-for-consumable
branch
from
323b4e6
to
e2ec45b
Compare
gerard-morera
force-pushed
the
feature/add-server-ack-for-consumable
branch
from
e2ec45b
to
925e398
Compare
|
@christophweegen and @jnbt thanks for your reviews. Renamed the typo and added the Readme. FYI; this code has already been working one week in production in my company. |
|
@christophweegen Please have a second look. If you're fine with it. Please merge and release |
馃搶 References
馃幆 What is the goal?
Perform server purchases acknowledgement.
Purchases ACK is used to confirm to google play that the purchase flow happened as expected. If the ACK does not happen the purchase is refunded within 4 minutes.
If the ACK is done from the client-side and the validation to the server fails it will make users that have paid not having it's correspondent capabilities active. This candy_check new feature will let acknowledge the purchase after capabilities grant.
馃摑 How is it being implemented?
Following Candy Check patterns and calling to Google API ACK service.