Skip to content

Commit

Permalink
chore!: use history as peer dependency
Browse files Browse the repository at this point in the history
BREAKING CHANGE: `history` must now be installed by consumers of this
library. The history instance creation functions are no longer
re-exported by this library and must be imported directly from
`history`.
  • Loading branch information
jneander committed Dec 19, 2022
1 parent c5a8306 commit 14db988
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 15 deletions.
17 changes: 11 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,6 @@
"author": "Jeremy Neander <jeremy.neander@gmail.com>",
"license": "MIT",
"homepage": "https://github.com/jneander/activity-routing-history",
"dependencies": {
"history": "^5.0.0"
},
"devDependencies": {
"@babel/eslint-parser": "^7.19.1",
"@jneander/activity-routing": "^2.0.3",
Expand All @@ -51,14 +48,16 @@
"eslint-plugin-import": "^2.22.1",
"eslint-plugin-mocha": "^10.0.0",
"eslint-plugin-promise": "^6.0.0",
"history": "^5.0.0",
"mocha": "^10.0.0",
"nodemon": "^2.0.15",
"prettier": "^2.8.1",
"sinon": "^15.0.0",
"typescript": "^4.9.4"
},
"peerDependencies": {
"@jneander/activity-routing": "^1.0.0 || ^2.0.0"
"@jneander/activity-routing": "^1.0.0 || ^2.0.0",
"history": "^5.0.0"
},
"prettier": "@jneander/prettier-config"
}
1 change: 0 additions & 1 deletion src/createBrowserHistory.js

This file was deleted.

1 change: 0 additions & 1 deletion src/createMemoryHistory.js

This file was deleted.

2 changes: 0 additions & 2 deletions src/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
export {createBrowserHistory} from './createBrowserHistory'
export {createMemoryHistory} from './createMemoryHistory'
export {Routing} from './Routing'
2 changes: 1 addition & 1 deletion src/specs/Routing.spec.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {expect} from 'chai'
import {createMemoryHistory} from 'history'
import sinon from 'sinon'

import {createMemoryHistory} from '../createMemoryHistory'
import {Routing} from '../Routing'
import {router} from './exampleRouter'

Expand Down

0 comments on commit 14db988

Please sign in to comment.