bugfix: don't test the truthiness of result

and add a test for atMost :X fixes #14
jneen · Feb 4, 2014 · aa99876 · aa99876
1 parent 2078914
commit aa99876
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/parsimmon.js b/src/parsimmon.js
@@ -168,7 +168,7 @@ Parsimmon.Parser = P(function(_, _super, Parser) {
         }
       }
 
-      for (; times < max && result; times += 1) {
+      for (; times < max; times += 1) {
         result = self._(stream, i);
         prevResult = furthestBacktrackFor(result, prevResult);
         if (result.status) {

diff --git a/test/parsimmon.test.js b/test/parsimmon.test.js
@@ -182,6 +182,15 @@ suite('parser', function() {
       assert.throws(function() { thenDigit.parse('x1'); });
     });
 
+    test('atMost', function() {
+      var atMostTwo = letter.atMost(2);
+      debugger
+      assertEqualArray(atMostTwo.parse(''), []);
+      assertEqualArray(atMostTwo.parse('a'), ['a']);
+      assertEqualArray(atMostTwo.parse('ab'), ['a', 'b']);
+      assert.throws(function() { atMostTwo.parse('abc'); });
+    });
+
     test('atLeast', function() {
       var atLeastTwo = letter.atLeast(2);