Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2nd attempt to fix travis build #219

Merged
merged 1 commit into from
Dec 26, 2017
Merged

2nd attempt to fix travis build #219

merged 1 commit into from
Dec 26, 2017

Conversation

bd82
Copy link
Contributor

@bd82 bd82 commented Dec 24, 2017

No description provided.

@coveralls
Copy link

coveralls commented Dec 24, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 6732234 on bd82:patch-3 into c77a49f on jneen:master.

@bd82
Copy link
Contributor Author

bd82 commented Dec 24, 2017

The problem was that the version of prettier was not locked
in the package.json, instead a wildcard (^) was used.
The locking was implemented using the package-lock file.

However, In older node.js versions (and thus npm versions)
this package-lock is not processed, causing a different version of prettier to be installed
with new formatting rules.

@wavebeem
Copy link
Collaborator

wavebeem commented Dec 26, 2017 via email

@wavebeem wavebeem merged commit 8865bfd into jneen:master Dec 26, 2017
@wavebeem
Copy link
Collaborator

Thanks for implementing this!

@bd82
Copy link
Contributor Author

bd82 commented Dec 27, 2017

I saw the pain in this commit message
c77a49f

and decided to help 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants