Fix issue where entire (very long) input is passed to bitSeq. #232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I need help writing a test that actually creates the problem I have fixed. In the binary parser I have constructed, when the parser runs, I am getting the entire input to bitSeq, when it's supposed to just operate on a slice of the input (when embedded as part of a large parsing context). I have fixed this issue, but I cannot seem to replicate it in a small test to prove it's an issue.
Can someone help me construct a proper test that will fail without this change?