get_env should accept JNI version as a parameter, like the C JNI function GetEnv does
#500
Comments
rib
added a commit
that referenced
this issue
Nov 20, 2023
JavaVM::get_env now requires the caller to determine that the JavaVM supports at least JNI 1.4 since there are two notable difficulties with trying to check the version internally: 1. There is a chicken and egg problem with trying to use `GetEnv` to get a `JNIEnv` from a `JavaVM` without knowing that it supports JNI 1.2 2. We require 1.4 as the minimum supported version but can't call `GetVersion` to validate a returned `JNIEnv` while there may be exceptions pending (since GetVersion is not in the list of JNI functions that are safe to call with pending exceptions). This also documents how `::get_env()` must not be used to materialize a (mutable) JNIEnv with a lifetime that doesn't correspond to the top JNI stack frame for local object references. Ref: #436 (reply in thread) Fixes: #500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
HotSpot seems to return the same
JNIEnvregardless of requested version (as long as that version is supported), but other JVMs could in theory return a differentJNIEnvdepending on which version you ask for.Originally posted by @argv-minus-one in #478 (comment)
The text was updated successfully, but these errors were encountered: