Guarantee that JNIEnv::fatal_error will not panic or allocate. Expa…
#480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argv-minus-one
added
enhancement
breaking
argv-minus-one
force-pushed
the
fatal-error-no-panic
branch
from
68e1398
to
9ecfd37
Compare
6 tasks
rib
force-pushed
the
rib/pr/jni-sys-0-4-port
branch
4 times, most recently
from
9be0bcd
to
538e94b
Compare
This also expands on the `JNIStr{,ing}` documentation.
rib
force-pushed
the
fatal-error-no-panic
branch
from
9ecfd37
to
1766412
Compare
rib
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a guarantee that
JNIEnv::fatal_errorwill not panic or allocate.This is needed in order to write a panic handler for native methods without the “
fatal_errorcan panic” problem described in #432 (comment).This has the downside (and breaking change) that
fatal_errornow takes a parameter of the exact type&JNIStr, which makes it somewhat more cumbersome to use. This PR expandsfatal_error's documentation to explain how to use it the easy way (like in the current version of thejnicrate), as well as how to prepare an error message string in a way that'sunsafebut panic- and allocation-free.This PR also expands the documentation of
JNIStrandJNIString.Note that CI testing has failed on this PR because
jni-sys0.4 is not in crates.io yet.Definition of Done