Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Speeds up
get_string
in two ways:java/lang/String
class instead of callingFindClass
repeatedly.IsInstanceOf
instead ofGetObjectClass
+IsAssignableFrom
.java/lang/String
is final, so these are equivalent.Running the benchmark on my machine, change 1:
Changes 1+2:
Fixed #530. Also incidentally fixes #528.
Questions/notes
std::OnceLock
, butget_or_try_init
is not yet stable, and I couldn't find a neat way to handle errors, hence pulling inonce_cell
. Open to ideas here.Thanks!
Definition of Done