Make jboolean an alias for bool instead of u8
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JNI only strictly defines two valid values for a `jboolean` and there's no consensus on whether other values greater than one will be interpreted as TRUE in all situations. The safest interpretation is to say that it will lead to undefined behaviour to pass any value besides zero or one as a `jboolean`. Addresses jni-rs/jni-rs#400 Closes #19
rib
force-pushed
the
rib/pr/add-get-module
branch
from
4a0ed67
to
f0db59a
Compare
rib
force-pushed
the
rib/pr/alias-jboolean-as-bool
branch
from
2aa4136
to
b478617
Compare
This was referenced Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JNI only strictly defines two valid values for a
jbooleanand there's no consensus on whether other values greater than one will be interpreted as TRUE in all situations.The safest interpretation is to say that it will lead to undefined behaviour to pass any value besides zero or one as a
jboolean.Addresses jni-rs/jni-rs#400
Closes #19