🐞 Bug Fix: Include napari.yaml in build#202
Merged
Merged
Conversation
Contributor
Author
|
@jni I don't think I caused that test to fail? I'm not sure why that's happening. |
Owner
|
https://github.com/jni/skan/actions/runs/5076459713/jobs/9118648227?pr=202#step:5:88
Looks like a new pandas or openpyxl release has stuffed us up... Well, that's probably another good reason for a new release! 😂 Do you mind trying to get to the bottom of it (install test deps in a clean environment and check that test) and making a separate PR for the fix? 🙏 |
jni
approved these changes
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that the napari plugin wasn't discovered when installing from
pypi.This was due to defining strict package data. I added
napari.yamlto that list.To check it worked, I built a wheel and installed from it locally.
This means we will need to release again, sorry @jni