Adjust has_select filters to allow invisible options in some cases

[naw]

This fixes #1579

• selected filter always allows invisible options
• options filter allows invisible options if the select
  itself is invisible
• with_options filter allows invisible options if the select
  itself is invisible

[twalpole]

I think it needs a test for a visible select with a non-visible but selected option - otherwise looks good to me

[naw]

My original HTML for the selected spec was actually like that, but then I noticed that selenium considers an invisible selected option as visible. That makes sense --- if you load a form with a pre-selected invisible option into Firefox or Chrome, the option is indeed visible.

Originally, I had a test to verify a visible select with an invisible option would not pass the options filter, but the selenium version of the test failed because selenium treated the invisible option as if it were visible. The RackTest and Chrome version of that test passed.

I can definitely adjust the spec per your suggestion, but in selenium I believe the spec would pass even without the code changes .... in other words, it would pass for the wrong reason(s) and not be testing the correct code path. Perhaps that's fine, as long as the other drivers do test the correct code path?

Any additional thoughts on this before I move forward?

[twalpole]

We're saying that a selected option is checked against selected whether it's visible or not, so if firefox happens to ignore display: none on an option that is selected I think it's fine -- other drivers may not and the test will be verifying that the option is included in the selected filter

[naw]

Added a commit to address your suggestion. I can squash it if it looks OK to you.

[twalpole]

looks good -- go ahead and squash and I'll merge it in

[naw]

Squashed. Thanks for your quick attention to this.

[twalpole]

thanks for the work!