Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] RSpec support policy #158

Closed
gongo opened this issue Jun 30, 2015 · 13 comments
Closed

[Proposal] RSpec support policy #158

gongo opened this issue Jun 30, 2015 · 13 comments
Assignees
Milestone

Comments

@gongo
Copy link
Collaborator

gongo commented Jun 30, 2015

Motivation

Now, jnicklas/turnip supports multiple version of RSpec (See: .travis.yml):

  • RSpec 2.14.x
  • RSpec 2.99.x
  • RSpec 3.0.x
  • RSpec 3.1.x
  • RSpec 3.2.x
  • RSpec 3.3.x

I think there are too many.

Proposed changes for support version

Ideally, latest version only.

But, I think everyone is not able to use the latest version.
And, many developers are using 2.14.x yet (maybe..).

Therefore, We propose the following policy:

  • Latest version
  • Previous version
  • 2.14.x version

Example:

  1. RSpec 3.3.x
  2. RSpec 3.2.x
  3. RSpec 2.14.x

In the future

When RSpec 4 was released, will stop support for RSpec 2.14.x.

@gongo gongo self-assigned this Jun 30, 2015
@a-suenami
Copy link
Contributor

LGTM 🍖

@KazuCocoa
Copy link
Contributor

I vote your your proposal, Latest version, Previous version and 2.14.x version.
It is enough in most cases, i suppose.

@PragTob
Copy link
Contributor

PragTob commented Jul 1, 2015

Keeping compatibility with many versions is difficult. People still using Rspec 2.14 can also keep using an older version of turnip which supports 2.14 imo. :)

E.g. if it were up to me I'd drop support for 2.x and make a new major release. And then only support 3.x or even 3.2+

@gongo
Copy link
Collaborator Author

gongo commented Jul 1, 2015

E.g. if it were up to me I'd drop support for 2.x and make a new major release. And then only support 3.x or even 3.2+

E.g.

  • turnip 1.3.x -> RSpec 3.x, RSpec 2.x
  • turnip 1.4.x (or 2.x) -> RSpec 3.x only

@PragTob
Copy link
Contributor

PragTob commented Jul 1, 2015

Make it 2.x as dropping support for a version is considered breaking and hence justifies a major version bump in semver. Good time to maybe make some other breaking changes :)

Thank you btw. for maintaining, I love turnip and over time feared it had gone unmaintained. Good to see that this is not the case 👍

@lukaso
Copy link
Contributor

lukaso commented Jul 2, 2015

While we're talking breaking changes, we'd love to get our rutabaga gem incorporated... It allows you to call features straight out of rspec (inverts the control). https://github.com/simplybusiness/rutabaga. Rutabaga is a lot closer to how CucumberJVM works, I think.

@gongo
Copy link
Collaborator Author

gongo commented Jul 3, 2015

Hi @lukaso

we'd love to get our rutabaga gem incorporated..

What's mean? "Rutabaga feature is provided as a built-in of Turnip" ?

@PragTob
Copy link
Contributor

PragTob commented Jul 3, 2015

@lukaso I believe this should rather be discussed in a separate issue :) Aside from that I believe that extra gems for extra/changed functionality are a good thing :)

@lukaso
Copy link
Contributor

lukaso commented Jul 3, 2015 via email

@gongo
Copy link
Collaborator Author

gongo commented Jul 7, 2015

Thank you for comment 🍕
I decided to RSpec support policy and major release plan.


When RSpec 3.4.0 is released, I will release Turnip 2.0.0.
Turnip 2.0.0 or later:

  • Not support RSpec 2.x
  • Support RSpec 3.x latest version and previous version
    • ex. RSpec 3.4.x + RSpec 3.3.x, RSpec 3.5.x + RSpec 3.4.x

If want to use RSpec 2, please use Turnip 1.3.x

@gongo gongo changed the title [WIP] [Proposal] RSpec support policy [Proposal] RSpec support policy Jul 7, 2015
@PragTob
Copy link
Contributor

PragTob commented Jul 7, 2015

👍

@gongo gongo closed this as completed Jul 7, 2015
@gongo
Copy link
Collaborator Author

gongo commented Jul 7, 2015

@gongo gongo added this to the Version 2.0.0 milestone Jul 7, 2015
@gongo
Copy link
Collaborator Author

gongo commented Nov 13, 2015

RSpec 3.4.0 was released 🎉
https://github.com/rspec/rspec-core/releases/tag/v3.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants