Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

place upper bound on gherkin dependency #169

Closed
munkyboy opened this issue Jan 12, 2016 · 3 comments
Closed

place upper bound on gherkin dependency #169

munkyboy opened this issue Jan 12, 2016 · 3 comments

Comments

@munkyboy
Copy link

https://github.com/cucumber/gherkin just released version 3.2 of their gem. The gem is now published as gherkin whereas before I think it was published as gherkin3. It seems turnip is not compatible with the v3 line of gherkin. I suggest limiting the dependency to the 2.x line.
@gongo
Copy link
Collaborator

gongo commented Jan 12, 2016

Hi @munkyboy

Thanks for report!
I will lock gherkin ~>2.5 soon.

gongo added a commit that referenced this issue Jan 13, 2016
@gongo
Lock gherkin version to 2.x GH-169
65f7a39
@gongo gongo mentioned this issue Jan 13, 2016
Merged
@gongo
Copy link
Collaborator

gongo commented Jan 13, 2016

@munkyboy

I've released turnip-2.0.2 that lock gherkin version to 2.x

@gongo gongo closed this as completed Jan 13, 2016
@munkyboy
Copy link
Author

awesome. thanks for the prompt response!

@gongo gongo mentioned this issue Jan 13, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@munkyboy @gongo