Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Gherkin4 #184

Merged
merged 2 commits into from Sep 22, 2016
Merged

Use Gherkin4 #184

merged 2 commits into from Sep 22, 2016

Conversation

krororo
Copy link
Contributor

@krororo krororo commented Sep 19, 2016

Close #171

@gongo
Copy link
Collaborator

gongo commented Sep 19, 2016

Hi @krororo
Thanks for PR. Please wait until check 🙇

gongo
gongo requested changes Sep 22, 2016
View reviewed changes
lib/turnip/builder.rb
parser = Gherkin::Parser.new
scanner = Gherkin::TokenScanner.new(File.read(feature_file))

result = parser.parse(scanner)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's enough the following code:

parser = Gherkin::Parser.new
result = parser.parse(File.read(feature_file))

@krororo
Copy link
Contributor Author

krororo commented Sep 22, 2016

@gongo Thanks for review. I fixed it.
Should I squash?

@gongo
Copy link
Collaborator

gongo commented Sep 22, 2016

Should I squash?

No need squash. Thanks!

@gongo gongo merged commit d4c9310 into jnicklas:master Sep 22, 2016
@krororo krororo deleted the use_gherkin4 branch September 22, 2016 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongo gongo gongo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krororo @gongo