Upgrade cucumber-gherkin to version 22 #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetizzo
changed the title
|
@jnicklas ping, that one is blocking the usage of google pub sub in some applications :) |
| @@ -10,7 +10,7 @@ def self.build(feature_file) | |||
| include_gherkin_document: true, | |||
| include_pickles: false | |||
| ) | |||
| result = messages.first&.gherkin_document&.to_hash | |||
| result = messages.first&.gherkin_document&.to_h | |||
There was a problem hiding this comment.
I think the following is better.
result = messages.first&.gherkin_document&.to_h(reject_nil_values: true)| @@ -19,7 +19,7 @@ Gem::Specification.new do |s| | |||
| s.require_paths = ["lib"] | |||
|
|
|||
| s.add_runtime_dependency "rspec", [">=3.0", "<4.0"] | |||
| s.add_runtime_dependency "cucumber-gherkin", "~> 14.0" | |||
| s.add_runtime_dependency "cucumber-gherkin", "~> 22.0" | |||
There was a problem hiding this comment.
Currently the latest version of cucumber-gherkin is 24.0.0.
I have confirmed that the test passes with version 24.0.0.
So "~> 24.0" should be used.
There was a problem hiding this comment.
And in 0-3 months, there will be a 25.0 followed by a 26.0 a few months after that. #244 will fix the issue for a lot longer. O:)
|
Thanks to #244 we do not depend on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 馃憢
This PR updates the
cucumber-gherkindependency in the Turnip gemspec to v22 from v14. The reason for this was a selfish one. 馃槃Our app is currently using Turnip v4.3.0, which has the following dependency tree:
I was attempting to add another gem, which depends on
google-protobuf = 3.18.0, but this caused a conflict with theprotobuf-cucumbergem that manifested in this error message:Since
cucumber-messages >= 16.0.0no longer depends onprotobuf-cucumberI figured that upgrading this dependency was the easiest path towards resolving this conflict.I have run the project tests against this PR locally and they all pass. I also added my fork to our app and everything seems to be working well with that as well FWIW.
Please let me know if there is any other testing that needs to be done or added and I will add that to this PR.
Thanks,
Jason