Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test updates #119

Merged
merged 8 commits into from
Jan 12, 2023
Merged

Test updates #119

merged 8 commits into from
Jan 12, 2023

Conversation

jnikula
Copy link
Owner

@jnikula jnikula commented Jan 11, 2023

A couple of fixes, and a bunch of changes to specify various files explicitly via the testcase yaml instead of deducing them from the filename. It's not quite enough to make it work for for subdirectories, but it's a good step in that direction.

@BrunoMSantos There's no rush with reviewing this one, I know you've got other priorities right now. More like FYI.

One of the strings using {domain} isn't an f-string.
Make the directive explicit instead of having implicit 'autodoc'.
Hide how exactly we're deducing the filename.
Specify the filename explicitly instead of deriving it from the testcase
name.
Specify the filename explicitly instead of deriving it from the testcase
name.
Unify the signature with the other functions to get filenames.
Copy link
Collaborator

@BrunoMSantos BrunoMSantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an easy review this one: it's good to go.

I would only add one more commit: now we could reuse most, if not all, the .rst files from the C cases for the C++ cases and maybe some of the .stderr ones.

It can be separate to the series though.

@jnikula jnikula merged commit 58bc677 into master Jan 12, 2023
@jnikula jnikula deleted the test-updates branch January 12, 2023 09:32
@jnikula
Copy link
Owner Author

jnikula commented Jan 12, 2023

I would only add one more commit: now we could reuse most, if not all, the .rst files from the C cases for the C++ cases and maybe some of the .stderr ones.

There aren't all that many exact dupes though. The domain is different. Unless we want to go for running format on the entire files, and have {domain} in there. But that's definitely for another time.

@BrunoMSantos
Copy link
Collaborator

I would only add one more commit: now we could reuse most, if not all, the .rst files from the C cases for the C++ cases and maybe some of the .stderr ones.

There aren't all that many exact dupes though. The domain is different. Unless we want to go for running format on the entire files, and have {domain} in there. But that's definitely for another time.

Ah, of course. Not a bad idea to support templating in expected results eventually though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants