Parser autodoc tests #133
Merged
Parser autodoc tests #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use get() instead of pop(), and rely on the implicit default None for get(). Bump copyright years while at it.
It's just confusing, use a separate name for directive options.
Start using a similar docstring walk in the parser test as in the extension implementation, in preparation for adding similar filters.
Add type, name and member filtering for docstring walk in order to support running the auto* directive tests on the parser directly, and skip fewer test cases. We find that we do need to adjust some expected results due to whitespace changes that the extension test via Sphinx normalizes to the same and ignores. We also need to add "public" to C++ struct/class members in expected results to match the direct parser output. The extension test via Sphinx drops them. This does not increase test coverage overall, but improves robustness at least wrt whitespace in the auto* directive output.
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve parser whitespace robustness for the non-autodoc auto* directives. See the last commit message for details.