Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document the C++ support #137

Merged
merged 1 commit into from
Feb 26, 2023
Merged

doc: document the C++ support #137

merged 1 commit into from
Feb 26, 2023

Conversation

jnikula
Copy link
Owner

@jnikula jnikula commented Feb 4, 2023

Document the C++ support, and clean up and clarify documentation while at it.

I went through all the documentation and tweaked stuff all around the C++ changes. The first sentence in the index.rst was a mouthful even before the C++ stuff, so I simplified it a lot. On the other hand, I added more details and references here and there.

I opted to leave out any warnings about rudimentary C++ support for now. We can add that before the release depending on what we have.


No arguments are passed by default when processing C domain
directives. ``-xc++`` is passed as the first argument when processing C++
domain directives.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this paragraph. It's technically accurate, but strictly from the view of a user, I worry it raises more questions than not.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left this change out.

@BrunoMSantos
Copy link
Collaborator

Other than that minor comment, I think it's pretty clear.

I opted to leave out any warnings about rudimentary C++ support for now. We can add that before the release depending on what we have.

I'd also argue against this one. You raised the good point before that merging this will expose these docs to some extent, even if there is no release yet. In fact I've just remembered that the official read the docs documentation is generated on the tip of master, we should probably fix that so that it happens only for tagged releases.

@jnikula
Copy link
Owner Author

jnikula commented Feb 5, 2023

Other than that minor comment, I think it's pretty clear.

I opted to leave out any warnings about rudimentary C++ support for now. We can add that before the release depending on what we have.

I'd also argue against this one. You raised the good point before that merging this will expose these docs to some extent, even if there is no release yet.

That was in reference to the README.rst changes, which I left out.

In fact I've just remembered that the official read the docs documentation is generated on the tip of master, we should probably fix that so that it happens only for tagged releases.

So it generates both "latest" and "stable" documentation, with the former being the tip of master, and the latter being the latest tagged release. As a quick fix, I changed the redirect of https://hawkmoth.readthedocs.io/ from latest to stable.

"latest" was a poor choice of wording in that it doesn't really convey "unreleased" like it should. (I don't even remember if that was my wording or RTD default or what.)

With the latest being deployed on github pages at https://jnikula.github.io/hawkmoth/ (though not referenced anywhere yet) it might be prudent to sunset latest from RTD.

@jnikula jnikula mentioned this pull request Feb 5, 2023
Document the C++ support, and clean up and clarify documentation while
at it.

[Jani: Go through it all in detail. Simplify the intro section in
index.rst, but add more details all around.]
@jnikula
Copy link
Owner Author

jnikula commented Feb 25, 2023

I guess we both ran out of steam/time a bit with this...

I made the minor update about clang options. With the version now more prominently displayed in the documentation sidebar, and the default being "stable" at readthedocs, I think it should be good enough now, to make some forward progress.

@BrunoMSantos
Copy link
Collaborator

I guess we both ran out of steam/time a bit with this...

Yeah, RL hasn't helped. I've kept an eye on this, but not in long enough stints to see anything through...

Nice to see the documentation improve though! Looks good to me.

@jnikula jnikula merged commit 68ecc7a into master Feb 26, 2023
@jnikula jnikula deleted the cpp-docs branch February 26, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants