Src hierarchy part 1 #150
Merged
Src hierarchy part 1 #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .PHONY part wasn't updated when the targets were renamed.
'pip install -e .' does not work with setup.cfg directly.
Install hawkmoth in editable mode for development and testing. Use strict mode to only use the packages described in setup.cfg [1]. This in itself does not yet detect broken packaging, because the current directory is in python path, and the packages can be found directly in the hawkmoth directory. Upgrading pip and setuptools seems to be necessary on some distros when using --system-site-packages to avoid issues. [1] https://setuptools.pypa.io/en/latest/userguide/development_mode.html#strict-editable-installs
|
Fail, back to the drawing board. |
jnikula
force-pushed
the
src-hierarchy-part-1
branch
from
7117ca0
to
6bbfde5
Compare
|
@BrunoMSantos Seems to work now. Also fixed the .PHONY stuff. |
|
Looks good! Not sure why it needs to be in 2 parts, but works for me. |
Yeah, maybe it wouldn't have needed to be, I had one idea why it failed and stuck to it even after reading your comment about the separate shells. Oh well. |
Yup, thought so, but it won't matter after the merge ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of #149 to hopefully pass CI.