Test multiple directives prep work #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare for multiple directives per testcase by adding an abstraction for directives.
Clean up the code, although it's not likely we'll use multiple directives in cli tests.
Prepare for supporting multiple directives per testcase.
Prepare for supporting multiple directives per testcase.
Do not support multiple directives per example for the time being, but use the same abstraction nonetheless.
The current testcase yaml schema does not lend itself to support multiple directives. Move all directive related options under a 'directives' list that can have an arbitrary number of directives.
Convert autostruct.yaml to a multiple directive testcase.
jnikula
force-pushed
the
test-multiple-directives
branch
from
f0a001b
to
2ea702a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To properly test directives where the source file is not specified, we'll need testcases to support multiple directives. This is prep work for that, converting the schema to support a list of directives.