Fix references to typedefs of anonymous struct/union/enum on clang 15 and earlier #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoMSantos
approved these changes
Nov 18, 2023
Clang 15 and earlier have None for the cursor.spelling of typedefs of anonymous structs/unions/enums. Clang 16 and later return the name of the typedef. We address this in decl_name to get the Docstring right across Clang versions, but the name filtering in Docstring._match() uses name. This results in us being unable to reference typedefs of anonymous entities with Clang 15 and earlier. Fix it up by returning decl_name as name from Doccursor if cursor.spelling is None. In the long run, we should unify on just name. The decl_name was always a workaround when we did the fixups in parser.py. With Doccursor, we should be able to further clean that up, but for the time being, close the known issue with the minimal fix. It's probably theoretical, but in the case *both* name and decl_name were None, we'd end up in infinite recursion if decl_name used self.name instead of self._cc.spelling. It's a bit of a wart, but should also be cleaned up later. Fixes #201
This used to fail with clang 15 and earlier.
Thanks, fixed & merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #201