Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: move flake8 filename patterns to setup.cfg #222

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Conversation

jnikula
Copy link
Owner

@jnikula jnikula commented Nov 19, 2023

Commit dc17f41 ("setup: move flake8 configuration to setup.cfg") moved flake8 ignore patterns and line length config to setup.cfg. Also move the filename patterns there.

Commit dc17f41 ("setup: move flake8 configuration to setup.cfg")
moved flake8 ignore patterns and line length config to setup.cfg. Also
move the filename patterns there.
Copy link
Collaborator

@BrunoMSantos BrunoMSantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well noted, but actually, seems like flake 8 already finds everything on its own, this is only needed if we don't want to apply it somewhere as an exception. Maybe we want to remove it altogether?

Otherwise it's fine.

@jnikula
Copy link
Owner Author

jnikula commented Nov 19, 2023

Well noted, but actually, seems like flake 8 already finds everything on its own, this is only needed if we don't want to apply it somewhere as an exception. Maybe we want to remove it altogether?

Then we'd need to add excludes, because it finds absolutely everything in the virtual environment, checks doc/conf.py, etc. I prefer it this way.

Otherwise it's fine.

@jnikula jnikula merged commit 9c20afb into master Nov 19, 2023
5 checks passed
@jnikula jnikula deleted the flake8-filename branch November 19, 2023 12:09
@BrunoMSantos
Copy link
Collaborator

Oh, ok. I personally like checking conf.py. Oh well, I'll fight that one some other day :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants