Macro named variable argument #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the expected first two tokens, and comment why we do the extent checks.
GCC and Clang support named variable argument FOO(args...) in addition to the standard FOO(...) and __VA_ARGS__. Handle it properly. Simply gather and concatenate all the tokens until the next "," or ")". The parsing remains rather simplistic.
|
Hey, sorry for taking so long. I reviewed this over the weekend but then forgot to say something 😅 Looks good to me though! |
Thanks, appreciated, as always! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the named variable argument in variadic macros i.e.
FOO(arg...)style, and remove a long standing FIXME comment.https://gcc.gnu.org/onlinedocs/cpp/Variadic-Macros.html