Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anonymous type detection for newer Clang version #74

Merged
merged 1 commit into from
Nov 20, 2021

Conversation

BrunoMSantos
Copy link
Collaborator

Clang 13 introduces a change to the anonymous type names forcing us to
update the regex to support both versions.

Clang 13 introduces a change to the anonymous type names forcing us to
update the regex to support both versions.
@jnikula jnikula merged commit e8bdf62 into jnikula:master Nov 20, 2021
@jnikula
Copy link
Owner

jnikula commented Nov 20, 2021

Thanks, and sorry for the delay! This is what I used to test the change:

diff --git a/docker/test/Dockerfile b/docker/test/Dockerfile
index fbd362deacc6..0bbdb6e1c5ca 100644
--- a/docker/test/Dockerfile
+++ b/docker/test/Dockerfile
@@ -1,8 +1,8 @@
-FROM debian:bullseye
+FROM debian:bookworm
 
 RUN apt-get update
 RUN apt-get install -y \
-       python3-clang \
+       python3-clang-13 \
        python3-pip
 RUN apt-get clean

At some point I think we'll have to define the version combinations of {Sphinx, Clang, Python} we want to test. But I guess for now we can still go ad hoc and fix issues as they arise.

@jnikula
Copy link
Owner

jnikula commented Nov 20, 2021

Oops, we both forgot to run the new make check target for flake8. I opted to push a fix directly: 6dae9be ("flake8: silence a E501 line too long with "noqa: E501"")

@BrunoMSantos BrunoMSantos deleted the fix-clang-13 branch April 11, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants